On Mon, Jul 14, 2014 at 5:43 PM, <Valdis.Kletnieks@xxxxxx> wrote: > On Mon, 14 Jul 2014 14:14:24 -0400, Nicholas Krause said: >> This patch addresses the fix me message in this file that states to >> remove all definitions not related to reg-clocks in this header >> file. >> >> Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx> >> --- >> arch/arm/mach-s3c64xx/include/mach/regs-clock.h | 22 +--------------------- >> 1 file changed, 1 insertion(+), 21 deletions(-) > >> -#endif /* _PLAT_REGS_CLOCK_H */ >> +/#endif /* _PLAT_REGS_CLOCK_H */ > > You're kidding us, right? Given that this was obviously *not* compile > tested at all, why should we believe that in fact all those #defines > are in fact no longer used? > > Hint: There's a very high chance that somebody stuck that FIXME in there rather > than just cleaning it up themselves precisely *because* it was still in use in > an inconvenient to fix place in the tree.. > I build the arch/arm directory I seem to me hitting a error. arch/arm/xen/enlighten.c:17:29: fatal error: asm/system_misc.h: No such file or directory #include <asm/system_misc.h> I am also looking into fixing this issue. Cheers Nick -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |