Re: [PATCH 1/1] ARM: exynos_defconfig: Update exynos_defconfig

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Doug,

On Mon, Jul 14, 2014 at 10:17 PM, Doug Anderson <dianders@xxxxxxxxxxxx> wrote:
> Sachin,
>
> On Wed, Jul 9, 2014 at 3:22 AM, Sachin Kamat <sachin.kamat@xxxxxxxxxxx> wrote:
>> Removed outdated configs. Enabled most of the configs used on latest
>> Exynos based platforms. This will provide a reference for users trying
>> to verify and test various features on Exynos based platforms and also
>> help in detecting breakages by widening the build coverage.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxxx>
>> ---
>>  arch/arm/configs/exynos_defconfig |   56 +++++++++++++++++++++++++++++++------
>>  1 file changed, 48 insertions(+), 8 deletions(-)
>
> How about "CONFIG_CPU_FREQ=y" + related configs?  I'm pretty sure that
> CPU_FREQ works on exynos5250-snow and the config didn't hurt last time
> I tried on exynos5420/5800.

I have left them out for now in the hope that they would soon get
obsoleted by the
latest patchset migrating to generic CPUFreq driver. I will send a
second round of
update around rc-7 based on the drivers prevalent then.

>
> Once Javier's changes land we'll need to add max77802 in here, but
> it's fine to leave it out until then.
>
> I'd also wonder about CONFIG_DRM eventually being set for graphics,
> but I'll admit to very little knowledge there.  That seems like it
> could be in a followup patch.

My plan was to include only basic things which are currently
functional in the first
round and then enable CPUFreq, DRM and PMIC (for 5420/5800) in the second round
(based on the merge status). Display/panel/bridge related patches are
not yet merged
and enabling hdmi, etc. would give errors as regulator is not
available. Again a second
round material.

>
> I would strongly suggest PREMPT_VOLUNTARY=y for now (again in a
> separate patch).

OK.

>With your config and 'slub_debug=FZPUA' I continue
> to get constant errors reported.  These errors are not your fault
> (they also show up on tegra boards).  I've already reported this and
> it's pretty much gone nowhere.
>
> Another suggestion is to enable the WiFi that's on ARM Chromebooks:
>   CONFIG_MWIFIEX=m
>   CONFIG_MWIFIEX_SDIO=m

OK.

>
> ...and that probably means some WiFi configs.  I'm not an expert, but
> possibly these.  The first of these appears to be needed to keep shill
> (present in the default ChromeOS rootfilesystem) from crashing wildly:
>   CONFIG_CFG80211=m
>   CONFIG_CFG80211_WEXT=y
>   CONFIG_MAC80211=m

OK. I would need someone to test these though.

>
>
> Possibly you should be enabling the battery eventually since
> Chromebooks have these too:
>   CONFIG_BATTERY_SBS=m

Sure.

>
> You're enabling the adc, but not what's hooked up to it:
>   CONFIG_SENSORS_NTC_THERMISTOR=m

OK.

>
> The eMMC that ships on Chromebooks has more than 8 partitions, so you
> probably should have this:
>   CONFIG_MMC_BLOCK_MINORS=16

OK.

>
> There's a light sensor on most ARM Chromebooks:
>   CONFIG_SENSORS_ISL29018=m

OK.

>
>
>
> All of the above could be in followup patches, so:
>
> Tested-by: Doug Anderson <dianders@xxxxxxxxxxxx>
> Reviewed-by: Doug Anderson <dianders@xxxxxxxxxxxx>

Thanks for your review and testing.

<snip>

>> +CONFIG_COMMON_CLK_S2MPS11=y
>> +CONFIG_EXYNOS_IOMMU=y
>> +CONFIG_IIO=y
>
> optional: You could probably =m this (and the ADC).  Better to test
> the =m case I think and there's no strong need for this to be in the
> kernel.

OK.

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux