On Thu, Jun 26, 2014 at 11:15 AM, Vikas Sajjan <vikas.sajjan@xxxxxxxxxxx> wrote:
> From: Doug Anderson <dianders@xxxxxxxxxxxx>
>
> The mask-tpm-reset GPIO is used by the kernel to prevent the TPM from
> being reset across sleep/wake. If we don't set it to anything then
> the TPM will be reset. U-Boot will detect this as invalid
> and will reset the system on resume time. This GPIO can always be low
> and not hurt anything. It will get pulled back high again during a
> normal warm reset when it will default back to an input.
>
> To properly preserve the TPM state across suspend/resume and to make
> the chrome U-Boot happy, properly set the GPIO to mask the
> reset to the TPM.
>
> Signed-off-by: Doug Anderson <dianders@xxxxxxxxxxxx>
> Signed-off-by: Vikas Sajjan <vikas.sajjan@xxxxxxxxxxx>
(...)
> + /* We need GPX0_6 to be low at sleep time; just keep it low always */
> + mask_tpm_reset_regulator: mask-tpm-reset-regulator {
> + compatible = "regulator-fixed";
No matter how the discussion ends up, regulator-fixed is wrong.
Either folding it into the TPM driver or using a separate reset driver
is fine with me.
So what about the generic delayed reset GPIO thing?
http://marc.info/?l=linux-kernel&m=140309916607115&w=2
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
