Hi Pankaj, On 25.06.2014 16:03, Pankaj Dubey wrote: > This patch moves PMU specific definitions into a new file > as exynos-pmu.h. > This will help in reducing dependency of common.h in pmu.c. > > Signed-off-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx> > --- > arch/arm/mach-exynos/common.h | 17 ----------------- > arch/arm/mach-exynos/exynos-pmu.h | 31 +++++++++++++++++++++++++++++++ > arch/arm/mach-exynos/pm.c | 1 + > arch/arm/mach-exynos/pmu.c | 2 +- > 4 files changed, 33 insertions(+), 18 deletions(-) > create mode 100644 arch/arm/mach-exynos/exynos-pmu.h > > diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h > index 296c6e1..0326ca2 100644 > --- a/arch/arm/mach-exynos/common.h > +++ b/arch/arm/mach-exynos/common.h > @@ -135,23 +135,6 @@ extern struct smp_operations exynos_smp_ops; > > extern void exynos_cpu_die(unsigned int cpu); > > -/* PMU(Power Management Unit) support */ > - > -#define PMU_TABLE_END (-1U) > - > -enum sys_powerdown { > - SYS_AFTR, > - SYS_LPA, > - SYS_SLEEP, > - NUM_SYS_POWERDOWN, > -}; > - > -struct exynos_pmu_conf { > - unsigned int offset; > - unsigned int val[NUM_SYS_POWERDOWN]; > -}; While at it, I'd say this struct could be moved to pmu.c, along with the PMU_TABLE_END macro as they are both private to this file. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html