On Mon, Jun 30, 2014 at 12:58:57PM +0200, Javier Martinez Canillas wrote: > >> + if (!max_gen->lookup) > >> + return ERR_PTR(-ENOMEM); > >> + > >> + max_gen->lookup->con_id = hw->init->name; > > > > Also IMO, init->name should be over-written if name is provided in DT, > > otherwise generic "clock-output-names" property will go futile, > > perhaps it should be done before clk_register. > > > > Even though Documentation/devicetree/bindings/clock/clock-bindings.txt says that > the "clock-output-names" property is optional I agree with you that will be > better to support it. So I'll add it on the next version as well. However, remember that con_id is the _DEVICE_ specific connection name, not the _CLOCK_ name. You will get a NAK from me if you violate this rule. -- FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly improving, and getting towards what was expected from it. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |