Hello Yadwinder, Thanks a lot for your feedback. On 06/26/2014 01:51 PM, Yadwinder Singh Brar wrote: > Hi Javier, > > Sorry for jumping in late, but just one concern mentioned inline. > > [ .. ] > >> + >> +static unsigned long max_gen_recalc_rate(struct clk_hw *hw, >> + unsigned long parent_rate) >> +{ >> + return 32768; >> +} > > Isn't more safer(correct), if it check and return 0 when clk is > disabled(unprepared) ? > Makes sense to me. I'll add a if (__clk_is_enabled(hw->clk)) check in the next version. > Regards, > Yadwinder > Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html