Re: [PATCH 1/2] usb: host: Kconfig: Select PHY drivers for Exynos EHCI/OHCI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Kishon,

On Thu, Jun 26, 2014 at 2:19 PM, Kishon Vijay Abraham I <kishon@xxxxxx> wrote:
> Hi Sachin,
>
> On Thursday 26 June 2014 11:09 AM, Sachin Kamat wrote:
>> EHCI and OHCI drivers on Exynos platforms do not work without their
>> corresponding SoC specific phy drivers. Hence it makes no sense to
>> keep these phy drivers as user selectable. Instead select them from
>> the respective USB configs to make things easier for the end user.
>> While at it enable 5250 phy for Exynos 5420 SoC too.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxxx>
>> Cc: Kishon Vijay Abraham I <kishon@xxxxxx>
>> ---
>>  drivers/phy/Kconfig      |   37 +++++++------------------------------
>>  drivers/usb/host/Kconfig |   10 ++++++----
>>  2 files changed, 13 insertions(+), 34 deletions(-)
>>
>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
>> index 16a2f067c242..7fe7ef5f1322 100644
>> --- a/drivers/phy/Kconfig
>> +++ b/drivers/phy/Kconfig
>
> <snip>
>
>>
>>  config USB_EHCI_EXYNOS
>> -       tristate "EHCI support for Samsung S5P/EXYNOS SoC Series"
>> -       depends on PLAT_S5P || ARCH_EXYNOS
>> -       help
>> -     Enable support for the Samsung Exynos SOC's on-chip EHCI controller.
>> +     tristate "EHCI support for Samsung S5P/EXYNOS SoC Series"
>> +     depends on PLAT_S5P || ARCH_EXYNOS
>> +     select PHY_SAMSUNG_USB2 if ARCH_EXYNOS
>
> I am skeptical to add select after the problems it created during previous
> releases.

If you could point me to some link/discussion about this, I could check if such
problem is applicable here. IMHO, there shouldn't be any in this case.

> Maybe use 'default y if ARCH_EXYNOS' in PHY_SAMSUNG_USB2 Kconfig?

I would prefer to use this option only if there is a strong objection
to doing it the
current way as I do not see any benefits of exposing the PHY entries
that are only
prerequisites for the USB functionality (in this case) to users.

Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux