Tushar, On Mon, Jun 23, 2014 at 11:43 PM, Tushar Behera <trblinux@xxxxxxxxx> wrote: > On 06/24/2014 02:19 AM, Doug Anderson wrote: >> This adds cros_ec to exynos5420-peach-pit and exynos5800-peach-pi, >> including: >> * The keyboard >> * The i2c tunnel >> * The tps65090 under the i2c tunnel >> * The battery under the i2c tunnel >> >> To add extra motivation, it should be noted that tps65090 is one of >> the things needed to get display-related FETs turned on for pit and >> pi. >> >> Note that this relies on a few outstanding changes: >> * Needs (spi: s3c64xx: fix broken "cs_gpios" usage in the driver) and >> (spi: s3c64xx: for DT platofrms always get the chipselect info from >> DT node) to work properly and match the documented bindings. See >> <https://patchwork.kernel.org/patch/4346701/> and >> <https://patchwork.kernel.org/patch/4346711/> >> >> Signed-off-by: Doug Anderson <dianders@xxxxxxxxxxxx> >> Tested-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx> > > Along with the dependency patches on next-20140623, tested keyboard on > Peach-Pi board. > > Tested-by: Tushar Behera <tushar.b@xxxxxxxxxxx> > > Some comments below. > >> --- >> Changes in v2: >> - Now just one patch since mfd patch landed. >> - Rebased to ToT linux-next >> >> arch/arm/boot/dts/exynos5420-peach-pit.dts | 145 +++++++++++++++++++++++++++++ >> arch/arm/boot/dts/exynos5800-peach-pi.dts | 145 +++++++++++++++++++++++++++++ >> 2 files changed, 290 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts >> index 7649982..581f385 100644 >> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts >> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts > >> + regulators { >> + dcdc1 { >> + ti,enable-ext-control; >> + }; >> + dcdc2 { >> + ti,enable-ext-control; >> + }; >> + dcdc3 { >> + ti,enable-ext-control; >> + }; >> + fet1 { > > "tps65090_fet1: fet1 {" ? > >> + regulator-name = "vcd_led"; >> + }; >> + tps65090_fet2: fet2 { > > I would suggest we add similar labels to fet1, fet3, fet4, fet5 and fet6 > also. That way it would be easy to reference them in subsequent DT nodes. > > Same comment for Peach-Pi dts file too. OK. I added it to all the regulators in tps65090. That'll probably be useful for Javier in his max77802 work. -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |