Hello,
On 2014-06-19 14:43, Daniel Drake wrote:
On Tue, Jun 17, 2014 at 10:25 AM, Marek Szyprowski
<m.szyprowski@xxxxxxxxxxx> wrote:
This patch moves some parts of exynos4412-odroidx.dts to common
exynos4412-odroid-common.dtsi file and adds support for Odroid X2 and
U2/U3 boards. X2 is same as X, but it has faster SoC module (1.7GHz
instead of 1.4GHz), while U2/U3 differs from X2 by different way of
routing signals to host USB hub. It also lacks some hw modules not yet
supported by those dts files (i.e. LCD & touch panel).
Thanks for this! It is working on ODROID-U2: at least eMMC/SD, LED, serial.
Just 2 minor questions from reviewing:
Odroid-X DTS used to have serial ports at 13820000 and 13830000, this
patch removes them, but leaves 2.
Right. I've forgot the UART port change. Now I've checked it again and
schematics reveals that Odroid X/X2 and U2/U3 has UART1 available on UART
connector. On the other hand U2/U3 have UART0 RX/TX lines on GPIO connector,
while X/X2 has UART3 lines on the LCD/GPIO connector.
I can understand the idea of removing entries for ports that are not
available on the board, but I've never seen an ODROID with 2 serial
ports - should we bring this down to just the 1 enabled serial port
that is accessible?
That would be best solution, but this way the tty driver name will change
from ttySAC1 to ttySAC0 for UART1 port. Until uart driver gets fixed, I
would keep all 4 uart defined on X/X2 and define only uart 0 and 1 on
U2/U3. I will fix this in the next version of Odroid patches.
Odroid-X DTS used to enable EHCI port 2, but with this refactoring, no
longer does. Intentional?
This was a bug in the initial patch adding usb support. X and X2 uses only
HSCI0 port (ehci port 1).
Thanks for your review!
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
