On 19.06.2014 14:21, Daniel Drake wrote: > On Tue, Jun 17, 2014 at 10:25 AM, Marek Szyprowski > <m.szyprowski@xxxxxxxxxxx> wrote: >> This patch adds support for common hardware modules available on all >> Exynos4412-based Odroid boards, which already have complete support in >> mainline kernel. This includes secure firmware calls, watchdog, g2d and >> fimc (mem2mem) multimedia accelerators. > > For the secure firmware, this is indeed required for U2/U3, otherwise > the system crashes in weird ways during early boot. If this entry also > makes sense for ODROID-X, I'm surprised it was not there already, does > it boot without it? It probably does, but certain things fail, such as secondary CPU bring-up. > > As for the watchdog, g2d and fimc, is there really any Exynos4412 > configuration where such components are not available? > Sorry if that is a silly question - just wondering why we wouldn't > enable these in exynos4412.dtsi. I believe they should all be enabled at highest possible level, as they don't have any board-specific hardware dependencies. Probably even in exynos4.dtsi for some of them (watchdog likely). Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html