On Tue, Jun 17, 2014 at 10:25 AM, Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> wrote: > This patch adds port sub-nodes to exynos4 ehci and ohci modules, which > are required by recently merged new exynos4 usb2 phy support. > > Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> I checked this against the DT binding documentation for the samsung,exynos4210-ohci and samsung,exynos4210-ehci nodes, and also the usb2 phy binding docs. Looks fine. Also tested on ODROID-U2, seems to be working: ehci-exynos: EHCI EXYNOS driver exynos-ehci 12580000.ehci: EHCI Host Controller exynos-ehci 12580000.ehci: new USB bus registered, assigned bus number 1 exynos-ehci 12580000.ehci: irq 102, io mem 0x12580000 exynos-ehci 12580000.ehci: USB 2.0 started, EHCI 1.00 ohci_hcd: USB 1.1 'Open' Host Controller (OHCI) Driver ohci-exynos: OHCI EXYNOS driver ...and the onboard USB (EHCI) ethernet adapter works. Nice. The only thing I don't quite understand is the relationship between EHCI and OHCI controllers, one being at 12580000 and the other at 1259000; the SoC docs (which I have not studied in detail) don't make this very clear to me - no registers listed at base address 12590000? Anyway, Reviewed-by: Daniel Drake <drake@xxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |