On Tue, 17 Jun 2014, Doug Anderson wrote:
> Simon,
>
> On Tue, Jun 17, 2014 at 8:43 PM, Simon Glass <sjg@xxxxxxxxxxxx> wrote:
> >> diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c
> >> index 09ca789..4d34f1c 100644
> >> --- a/drivers/mfd/cros_ec_spi.c
> >> +++ b/drivers/mfd/cros_ec_spi.c
> >> @@ -289,21 +289,23 @@ static int cros_ec_cmd_xfer_spi(struct cros_ec_device *ec_dev,
> >> goto exit;
> >> }
> >>
> >> - /* check response error code */
> >> ptr = ec_dev->din;
> >> - if (ptr[0]) {
> >> - if (ptr[0] == EC_RES_IN_PROGRESS) {
> >> - dev_dbg(ec_dev->dev, "command 0x%02x in progress\n",
> >> - ec_msg->command);
> >> - ret = -EAGAIN;
> >> - goto exit;
> >> - }
> >> - dev_warn(ec_dev->dev, "command 0x%02x returned an error %d\n",
> >> - ec_msg->command, ptr[0]);
> >> - debug_packet(ec_dev->dev, "in_err", ptr, len);
> >> - ret = -EINVAL;
> >> +
> >> + /* check response error code */
> >> + ec_msg->result = ptr[0];
> >> + switch (ec_msg->result) {
> >> + case EC_RES_SUCCESS:
> >> + break;
> >> + case EC_RES_IN_PROGRESS:
> >> + ret = -EAGAIN;
> >> + dev_dbg(ec_dev->dev, "command 0x%02x in progress\n",
> >> + ec_msg->command);
> >> goto exit;
> >> + default:
> >> + dev_warn(ec_dev->dev, "command 0x%02x returned %d\n",
> >> + ec_msg->command, ec_msg->result);
> >> }
> >
> > Since this code is the same as the above, should it go in a common
> > function in cros_ec?
>
> So you are thinking it should be written like:
>
> ec_msg->result = ptr[0];
> ret = cros_ec_check_result(ec_dev, ec_msg);
> if (ret)
> goto exit;
>
> ---
>
> int cros_ec_check_result(struct cros_ec_device *ec_dev, struct
> cros_ec_command *ec_msg)
> {
> switch (ec_msg->result) {
> case EC_RES_SUCCESS:
> return 0;
> case EC_RES_IN_PROGRESS:
> dev_dbg(ec_dev->dev, "command 0x%02x in progress\n",
> ec_msg->command);
> return -EAGAIN;
> default:
> dev_warn(ec_dev->dev, "command 0x%02x returned %d\n",
> ec_msg->command, ec_msg->result);
> return 0;
> }
>
> OK, that seems reasonable. I'll plan to spin tomorrow with that.
+1
I'll do a proper review when you re-spin the patch.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
