Hi Doug, On 17 June 2014 21:22, Doug Anderson <dianders@xxxxxxxxxxxx> wrote: > > Simon, > > On Tue, Jun 17, 2014 at 8:39 PM, Simon Glass <sjg@xxxxxxxxxxxx> wrote: > > Hi Doug, > > > > On 16 June 2014 14:39, Doug Anderson <dianders@xxxxxxxxxxxx> wrote: > >> From: Bill Richardson <wfrichar@xxxxxxxxxxxx> > >> > >> struct cros_ec_device has a superfluous "name" field. We can get all the > >> debugging info we need from the existing ec_name and phys_name fields, so > >> let's take out the extra field. > > > > Except that it no longer prints I2C/SPI - i.e. the transport that is > > used. Is that not considered important? > > Before this change: > [ 1.895472] cros-ec-spi spi2.0: Chrome EC (SPI) > > After this change: > [ 1.910671] cros-ec-spi spi2.0: Chrome EC device registered > > > I think having SPI in the name twice is probably enough. ;) Ah that helps! Could have been in the commit message. Reviewed-by: Simon Glass <sjg@xxxxxxxxxxxx> Regards, Simon -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |