Re: [PATCH] ARM: Exynos : Fix build error with thumb2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/04/14 17:07, Santosh Shukla wrote:
On 2 June 2014 15:40, Dave Martin<Dave.Martin@xxxxxxx>  wrote:
On Mon, May 26, 2014 at 09:23:45PM +0530, Santosh Shukla wrote:
From: santosh shukla<santosh.shukla@xxxxxxxxxx>

Add non-global symbol .LLl2x0_regs_phys to avoid build break in thumb2 mode.

IIUC, arm assembler fail to load value of "global" variable
l2xo_regs_phys for thum2 mode and wrapping it in non-global symbol like
.Ll2x0_regs_phys solves the build break issue.

arch/arm/mach-exynos/sleep.S: Assembler messages:
arch/arm/mach-exynos/sleep.S:57: Error: invalid immediate for address
calculation (value = 0x00000004)

fix inspired from [1]

[1] https://lkml.org/lkml/2010/3/31/235

Signed-off-by: santosh shukla<santosh.shukla@xxxxxxxxxx>

Reviewed-by: Dave Martin<Dave.Martin@xxxxxxx>


Thanks.

Hi Kukjin, if this patch ok with you then can you pick it up.

Sure, I've applied this into fixes for 3.16.

Thanks,
Kukjin


The binutils folks insist that this is not a bug in gas.  (I disagreed, but
it's a grey area.)  This is the established pattern for working round this
issue -- looks fine to me.

Cheers
---Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux