On 10.06.2014 21:58, Doug Anderson wrote: > Tomasz, > > On Tue, Jun 10, 2014 at 12:49 PM, Tomasz Figa <tomasz.figa@xxxxxxxxx> wrote: >> This is wrong. The "cs-gpios" property is supposed to be an array, >> indexed by chip select number of SPI devices (indicated by their "reg" >> properties). >> >> Moreover, is there a need to parse this manually in this driver? I can >> see respective parsing code in of_spi_register_master(). > > I noticed this too (see my response), but I was confused about the > fact that nobody else uses the array created by > of_spi_register_master(). Any idea why? Hmm, I can see of_spi_register_master() assigning allocated pointer to master->cs_gpios, which is then used in spi_add_device() as follows: if (master->cs_gpios) spi->cs_gpio = master->cs_gpios[spi->chip_select]; Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |