Hi Naveen, On Tue, Jun 10, 2014 at 2:30 PM, Naveen Krishna Chatradhi <ch.naveen@xxxxxxxxxxx> wrote: > This patch returns an integer error value instead of the > pointer. > > "warning: return makes integer from pointer without a cast" > > Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@xxxxxxxxxxx> > Cc: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx> > Cc: Doug Anderson <dianders@xxxxxxxxxxxx> > --- > drivers/spi/spi-s3c64xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c > index 0c6013f..4594dde 100644 > --- a/drivers/spi/spi-s3c64xx.c > +++ b/drivers/spi/spi-s3c64xx.c > @@ -817,7 +817,7 @@ static int s3c64xx_spi_setup(struct spi_device *spi) > > if (!spi->dev.of_node) { > dev_err(&spi->dev, "device node not found\n"); > - return ERR_PTR(-EINVAL); > + return -EINVAL; Isn't this warning introduced by the previous patch (patch1/3)? If so then this patch should be squashed into that. -- Regards, Sachin. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html