Re: [PATCH] ARM: EXYNOS: Use wfi macro in platform_do_lowpower

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 22 May 2014, Daniel Lezcano wrote:

> On 05/22/2014 09:57 AM, Leela Krishna Amudala wrote:
> > This patch is originally based on commit b3377d186572 ("ARM: 7064/1:
> > vexpress: Use wfi macro in platform_do_lowpower.")
> >
> > Current Exynos CPU hotplug code includes a hardcoded WFI
> > instruction, in ARM encoding.  When the kernel is compiled in Thumb-2
> > mode, this is invalid and causes the machine to hang hard when a CPU
> > is offlined.
> >
> > Use wfi macro instead of the hardcoded WFI instruction.
> 
> Is it possible to change it for cpu_do_idle() ?

Please let's not encourage every wfi() to be turned into cpu_do_idle().  
They are not always equivalent.  And semantically they are not.


Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux