On 5/19/14, Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > On Sun, May 18, 2014 at 01:50:36PM +0530, Ajay kumar wrote: >> On Sun, May 18, 2014 at 2:44 AM, Thierry Reding >> <thierry.reding@xxxxxxxxx> wrote: >> > On Thu, May 15, 2014 at 05:10:16PM +0530, Ajay kumar wrote: >> >> On Thu, May 15, 2014 at 1:43 PM, Thierry Reding >> >> <thierry.reding@xxxxxxxxx> wrote: >> > [...] >> >> > I still don't see how controlling the enable GPIO from the panel will >> >> > be >> >> > in any way better, or different for that matter, from simply >> >> > enabling >> >> > the backlight and let the backlight driver handle the enable GPIO. >> >> > Have >> >> > you tried to do that and found that it doesn't work? >> >> It works, but it gives me glitch when I try to configure video. >> >> This is because backlight_on(pwm-backlight) happens much before >> >> I configure video(inside drm), and while configuring video there would >> >> be a glitch, >> >> and that glitch would be visible to the user since backlight is already >> >> enabled. >> > >> > Okay, so this means that your backlight is turned on too early. Instead >> > of working around that problem by moving control of the backlight >> > enable >> > GPIO from the backlight driver into the panel driver, the correct way >> > to >> > fix it is to make sure the backlight stays off until video is ready. >> Ok. Please suggest an idea how to do the same! > > I did post a patch[0] a long time ago that added a way to fix this for > pwm-backlight at least. I have tried this. We have to wait till the userspace to switch the backlight on again :( >> I have already suggested a simple idea which conforms to a valid spec. >> Just because enable_gpio is already a part of pwm_bl.c, I somewhat feel >> like we are forcing people to handle enable_gpio inside pwm_bl.c. > > And that's a good thing. That's what people will expect. Backlights are > exposed via sysfs, which is currently also the only way to control the > backlight from userspace. If the driver for that doesn't have everything > required to control the backlight how can userspace control it? This is a valid point, only at the hardware level. But if you consider a user experience perspective, user still will not be able to see the backlight even though enable_gpio is controlled elsewhere, since pwm is disabled anyhow. Now lets talk about backlight_on case. Even though user tries to turn on the backlight, and the driver turns on backlight supply, pwm and enable_gpio, the driver cannot always guarantee him that backlight is "really on" since it also depends on panel power. Such ambiguities exist for few panels. And, for such panels why can't we keep enable_gpio in another driver, and let the pwm_bl control only backlight levels? >> Note that, pwm_bl can still work properly without enabling the backlight >> GPIO. >> And, I did point out to a valid datasheet from AUO, which clearly >> indicates why >> backlight enable GPIO should be a part of panel driver and not pwm_bl >> driver. > > Just because some spec mentions the backlight enable pin in some panel > power up sequence diagram that doesn't mean we have to implement it as > part of the panel driver. That is not "some spec". I believe all the AUO panels share the same sequence! >> I am not trying to say we should remove enable_gpio from pwm_bl. >> Provided that its already an optional property, and if someone wants >> to control it in a panel driver, what is wrong in doing so? > > See above. > > Thierry > > [0]: https://lkml.org/lkml/2013/10/7/188 > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |