On Wed, 14 May 2014, Chander Kashyap wrote: > On 14 May 2014 08:32, Nicolas Pitre <nicolas.pitre@xxxxxxxxxx> wrote: > > On Wed, 14 May 2014, Chander Kashyap wrote: > >> On 14 May 2014 08:14, Abhilash Kesavan <kesavan.abhilash@xxxxxxxxx> wrote: > >> > On Tue, May 13, 2014 at 10:18 PM, Lorenzo Pieralisi > >> > <lorenzo.pieralisi@xxxxxxx> wrote: > >> >> On Tue, May 13, 2014 at 12:58:44PM +0100, Abhilash Kesavan wrote: > >> >> > >> >>> + /* > >> >>> + * Future entries into the kernel can now go > >> >>> + * through the cluster entry vectors. > >> >>> + */ > >> >>> + __raw_writel(virt_to_phys(mcpm_entry_point), > >> >>> + ns_sram_base_addr + MCPM_BOOT_ADDR_OFFSET); > >> >>> + > >> >> > >> >> ns_sram_base_addr must be unmapped, since it is unused after the write. > >> > Will unmap. > >> > >> This mapping is required in for cpuilde (suspend) to program > >> mcpm_entry before going to suspend. > > > > Why? > > This is required to program the mcpm_entry point address (resume > address) after cpuidle exit/fail. You should be using mcpm_set_entry_vector() for that. Once mcpm_entry_point is set, it shouldn't need to be changed. Nicolas -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html