Hi Pankaj,
[...]
>> #include "exynos-pmu.h"
>> #include "regs-pmu.h"
>> +#include "common.h"
>>
>
>
> I think it will be better if we move "EXYNOS5420_USE_STANDBY_WFI_ALL"
> macro into regs-pmu.h itself. It will help us removing dependency of
> common.h
> from "pmu.c", so that in future we can easily move this file out of machine
> directory.
Will move to regs-pmu.h
[...]
>> + * exynos_set_core_flag - set the cluster id to IROM register
>> + * to ensure that we wake up with the
>> + * current cluster.
>> + */
>> +static void exynos5420_set_core_flag(void)
>> +{
>> + unsigned int this_cluster;
>> + this_cluster = MPIDR_AFFINITY_LEVEL(read_cpuid_mpidr(), 1);
>> +
>> + regmap_write(pmu_context->pmu_regmap, EXYNOS_IROM_DATA2,
>> this_cluster);
>> +}
>> +
>> +void exynos5420_powerdown_conf(enum sys_powerdown mode)
>> +{
>> + exynos5420_set_core_flag();
>
>
> I think we can avoid extra function call of exynos5420_set_core_flag by
> moving
> all of it's code in powerdown_conf itself.
Will move to powerdown_conf.
>
>
>> +}
>> void exynos5_powerdown_conf(enum sys_powerdown mode)
>> {
>> unsigned int i;
>> @@ -429,6 +670,80 @@ static void exynos5250_pmu_init(void)
>> regmap_write(pmu_regmap, EXYNOS5_MASK_WDTRESET_REQUEST, tmp);
>> }
>> +static void exynos5420_pmu_init(void)
>> +{
>> + unsigned int value;
>> + int i;
>> +
>> + /*
>> + * Set the CMU_RESET, CMU_SYSCLK and CMU_CLKSTOP registers
>> + * for local power blocks to Low initially as per Table 8-4:
>> + * "System-Level Power-Down Configuration Registers".
>> + */
>> + for (i = 0; i < ARRAY_SIZE(exynos5420_list_disable_pmu_reg); i++)
>> + regmap_write(pmu_context->pmu_regmap,
>> + exynos5420_list_disable_pmu_reg[i], 0);
>> +
>> + /* Time taken to stabilized XXTI clock */
>> + regmap_write(pmu_context->pmu_regmap, EXYNOS5_XXTI_DURATION3,
>> 0x005dc);
>
>
> Isn't it will be good if you use some macro of 0x005dc?
Will remove this as per Alim's comment.
Regards,
Abhilash
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
