On 8 May 2014 12:50, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote: > On Thursday, May 08, 2014 3:20 PM, Rahul Sharma wrote: >> >> From: Rahul Sharma <Rahul.Sharma@xxxxxxxxxxx> >> >> Enable fimd node for snow board. >> >> Signed-off-by: Rahul Sharma <Rahul.Sharma@xxxxxxxxxxx> >> --- >> arch/arm/boot/dts/exynos5250-snow.dts | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts >> index 1ce1088..796954c 100644 >> --- a/arch/arm/boot/dts/exynos5250-snow.dts >> +++ b/arch/arm/boot/dts/exynos5250-snow.dts >> @@ -206,4 +206,10 @@ >> clock-frequency = <24000000>; >> }; >> }; >> + >> + fimd@14400000 { >> + status = "okay"; > > (+cc Sachin Kamat, Tomasz Figa) > > For readability, how about moving 'status' to the last entry of > the node? The same comment applies to other patches, too. Either at the top or bottom is fine rather than somewhere in between. However no need to re-spin the patch just for this change. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html