Hi Tomasz, Thanks for the review. On Tue, May 6, 2014 at 11:31 PM, Tomasz Figa <tomasz.figa@xxxxxxxxx> wrote: > Shaik, > > > On 06.05.2014 18:26, Shaik Ameer Basha wrote: >> >> This patch renames the mux parent arrays as per the naming >> convension followed by the other exynos specific clock drivers. >> >> Signed-off-by: Rahul Sharma <rahul.sharma@xxxxxxxxxxx> >> Signed-off-by: Shaik Ameer Basha <shaik.ameer@xxxxxxxxxxx> >> Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx> >> --- >> drivers/clk/samsung/clk-exynos5420.c | 359 >> ++++++++++++++++++---------------- >> 1 file changed, 186 insertions(+), 173 deletions(-) >> >> diff --git a/drivers/clk/samsung/clk-exynos5420.c >> b/drivers/clk/samsung/clk-exynos5420.c >> index 7a9e3b4..831670d 100644 >> --- a/drivers/clk/samsung/clk-exynos5420.c >> +++ b/drivers/clk/samsung/clk-exynos5420.c > > > [snip] > > >> static struct samsung_mux_clock exynos5420_mux_clks[] __initdata = { >> - MUX(0, "mout_mspll_kfc", mspll_cpu_p, SRC_TOP7, 8, 2), >> - MUX(0, "mout_mspll_cpu", mspll_cpu_p, SRC_TOP7, 12, 2), >> - MUX(0, "mout_apll", apll_p, SRC_CPU, 0, 1), >> - MUX(0, "mout_cpu", cpu_p, SRC_CPU, 16, 1), >> - MUX(0, "mout_kpll", kpll_p, SRC_KFC, 0, 1), >> - MUX(0, "mout_cpu_kfc", kfc_p, SRC_KFC, 16, 1), >> + MUX(0, "mout_mspll_kfc", mout_mspll_cpu_p, SRC_TOP7, 8, 2), >> + MUX(0, "mout_mspll_cpu", mout_mspll_cpu_p, SRC_TOP7, 12, 2), >> + MUX(0, "mout_apll", mout_apll_p, SRC_CPU, 0, 1), >> + MUX(0, "mout_cpu", mout_cpu_p, SRC_CPU, 16, 1), >> + MUX(0, "mout_kpll", mout_kpll_p, SRC_KFC, 0, 1), >> + MUX(0, "mout_kfc", mout_kfc_p, SRC_KFC, 16, 1), > > > Here the clock name is also changed, but I'll just fix the commit message > when applying, assuming that this change doesn't break anything. Ok. anyways I will try to update the commit message in the next series. Regards, Shaik > > >> >> - MUX(0, "sclk_bpll", bpll_p, SRC_CDREX, 0, 1), >> + MUX(0, "sclk_bpll", mout_bpll_p, SRC_CDREX, 0, 1), > > > [snip] > > >> static struct samsung_div_clock exynos5420_div_clks[] __initdata = { >> DIV(0, "div_arm", "mout_cpu", DIV_CPU0, 0, 3), >> DIV(0, "sclk_apll", "mout_apll", DIV_CPU0, 24, 3), >> DIV(0, "armclk2", "div_arm", DIV_CPU0, 28, 3), >> - DIV(0, "div_kfc", "mout_cpu_kfc", DIV_KFC0, 0, 3), >> + DIV(0, "div_kfc", "mout_kfc", DIV_KFC0, 0, 3), > > > Same here. > > Best regards, > Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html