Hi,
On 27.03.2014 07:13, Vikas Sajjan wrote:
From: Abhilash Kesavan <a.kesavan@xxxxxxxxxxx>
Add support for the suspend/resume button (SW7) on SMDK5420 using
gpio-keys driver.
Signed-off-by: Abhilash Kesavan <a.kesavan@xxxxxxxxxxx>
Signed-off-by: Vikas Sajjan <vikas.sajjan@xxxxxxxxxxx>
---
arch/arm/boot/dts/exynos5420-smdk5420.dts | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index 6910485..5ae0dd4 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -158,6 +158,17 @@
};
};
+ gpio-keys {
+ compatible = "gpio-keys";
+
+ wakeup {
Is wakeup the label of this key on the PCB? The "label" property below
would suggest otherwise. This should probably be called key-sw7 or
something like this.
Moreover, is this the only GPIO key on the board? If there are also
SW0-SW6, you should add them too.
+ label = "SW7";
+ gpios = <&gpx0 0 1>;
+ linux,code = <143>; /* KEY_WAKEUP */
Why not use KEY_WAKEUP defined in include/dt-bindings/input/input.h
directly?
Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
