Hi Chanwoo, On 10 April 2014 15:36, Chanwoo Choi <cw00.choi@xxxxxxxxxxx> wrote: > From: Tomasz Figa <t.figa@xxxxxxxxxxx> > > This patch add new exynos3250.dtsi to support Exynos3250 SoC and includes > chipid/sys_reg dt node. > > Signed-off-by: Tomasz Figa <t.figa@xxxxxxxxxxx> > Signed-off-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > --- > arch/arm/boot/dts/exynos3250.dtsi | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > create mode 100644 arch/arm/boot/dts/exynos3250.dtsi > > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi > new file mode 100644 > index 0000000..3c8cee6 > --- /dev/null > +++ b/arch/arm/boot/dts/exynos3250.dtsi > @@ -0,0 +1,34 @@ > +/* > + * Samsung's Exynos3250 SoC device tree source > + * > + * Copyright (c) 2014 Samsung Electronics Co., Ltd. > + * http://www.samsung.com > + * > + * Samsung's Exynos3250 SoC device nodes are listed in this file. Exynos3250 > + * based board files can include this file and provide values for board specfic > + * bindings. > + * > + * Note: This file does not include device nodes for all the controllers in > + * Exynos3250 SoC. As device tree coverage for Exynos3250 increases, additional > + * nodes can be added to this file. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > + > +#include "skeleton.dtsi" > + > +/ { > + compatible = "samsung,exynos3250"; > + > + chipid@10000000 { > + compatible = "samsung,exynos4210-chipid"; > + reg = <0x10000000 0x100>; > + }; > + > + sys_reg: syscon@10010000 { > + compatible = "samsung,exynos3-sysreg", "syscon"; > + reg = <0x10010000 0x400>; > + }; > +}; Shouldn't these be grouped under the soc node? -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html