On Thu, Apr 10, 2014 at 11:04:59AM +0100, Marc Zyngier wrote: > On Thu, Apr 10 2014 at 10:28:24 am BST, Chanwoo Choi <cw00.choi@xxxxxxxxxxx> wrote: > > This patch declare coretex-a7's irqchip to initialze gic from dt > > with "arm,cortex-a7-gic" data. > > > > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > > Signed-off-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> > > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > > --- > > drivers/irqchip/irq-gic.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c > > index 4300b66..8e906e4 100644 > > --- a/drivers/irqchip/irq-gic.c > > +++ b/drivers/irqchip/irq-gic.c > > @@ -1069,6 +1069,7 @@ gic_of_init(struct device_node *node, struct device_node *parent) > > } > > IRQCHIP_DECLARE(cortex_a15_gic, "arm,cortex-a15-gic", gic_of_init); > > IRQCHIP_DECLARE(cortex_a9_gic, "arm,cortex-a9-gic", gic_of_init); > > +IRQCHIP_DECLARE(cortex_a7_gic, "arm,cortex-a7-gic", gic_of_init); > > IRQCHIP_DECLARE(msm_8660_qgic, "qcom,msm-8660-qgic", gic_of_init); > > IRQCHIP_DECLARE(msm_qgic2, "qcom,msm-qgic2", gic_of_init); > > Frankly, this patch adds no value. Are we going to add > "arm,cortex-a12-gic", "arm,cortex-a17-gic", "arm,cortex-a53-gic", > "arm,cortex-a57-gic"? And that's just to mention the ARM Ltd cores... > > Instead, how about defining a generic "arm,gic" property, and mandate > that new DT files are using that? We can always use a more precise > compatible for quirks. Nit: s/property/compatible/ As mentioned elsewhere, "arm,gic-v2" would seem to fit the bill (and we can have "arm,gic" or "arm,gic-v1" for v1). > Mark, what do you think? I think this has been discussed in the past > already. It's been repeatedly brought up and agreed on, it's just that no-one's implemented it. I agree that having an "arm,gic-v2" binding that people can place in their compatible list is a sensible thing to do, and I'd be happy to Ack patches implementing it. Cheers, Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |