Re: [PATCH V2 16/17] ARM: exynos: cpuidle: Move the driver to drivers/cpuidle directory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/07/2014 11:51 AM, Sachin Kamat wrote:
Hi Daniel,

On 4 April 2014 19:13, Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> wrote:
Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
Reviewed-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
---
  arch/arm/mach-exynos/Makefile                      |    1 -
  drivers/cpuidle/Kconfig.arm                        |    7 +++++++
  drivers/cpuidle/Makefile                           |    1 +
  .../cpuidle.c => drivers/cpuidle/cpuidle-exynos.c  |    0
  4 files changed, 8 insertions(+), 1 deletion(-)
  rename arch/arm/mach-exynos/cpuidle.c => drivers/cpuidle/cpuidle-exynos.c (100%)

This driver now references platform header file (plat/cpu.h) for some
Exynos5440 specific check
which is not good considering multiplatform support. Any plan to get
rid of this?

Yes. Prevent to register the platform device for this board and remove these lines in the driver.

What is the benefit of having a single state WFI cpuidle driver ? That pulls all the governor computation and decision for nothing.



--
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux