On Wed, Mar 05, 2014 at 11:42:19AM -0700, Jason Gunthorpe wrote: > On Wed, Mar 05, 2014 at 02:25:51PM +0100, Lucas Stach wrote: > > - return pp->irq; > > + irq = of_irq_parse_and_map_pci(dev, slot, pin); > > + if (!irq) > > + irq = pp->irq; > > In light of the two bugs that Tim found, it might be wise to throw a > 'dev_warn(FW_BUG "Missing DT interrupt mapping")' in the fall back > path, so it doesn't continue to silently cover up errors on the OF/DT > side.. This sounds like a reasonable thing to do, but I didn't see a response to this comment. Should I merge it as-is, or do you want to add the message? -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |