Quoting Tarek Dakhran (2014-02-23 19:43:54) > +External clock: > + > +There is clock that is generated outside the SoC. It is expected > +that it is defined using standard clock bindings with following > +clock-output-name: > + - "fin_pll" - PLL input clock - required. <snip> > +Example 2: Required external clock. > + > + fin_pll: clock-fin-pll { > + compatible = "fixed-clock"; > + reg = <0>; > + #clock-cells = <0>; > + clock-frequency = <24000000>; > + clock-output-names = "fin_pll"; > + }; I guess this part is a little strange for a binding definition. Basically this is DTS data specific to 5410; not sure why it belongs in the DT binding definition. Rest of the clock driver appears OK to me. Regards, Mike -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html