Re: [PATCH v2 1/3] ARM: EXYNOS: Map PMU address through DT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 17.03.2014 15:23, Sachin Kamat wrote:
Hi Vikas,

On 17 March 2014 18:39, Vikas Sajjan <vikas.sajjan@xxxxxxxxxxx> wrote:
Instead of hardcoding the PMU details for each SoC, pass this information
through device tree (DT).

Signed-off-by: Vikas Sajjan <vikas.sajjan@xxxxxxxxxxx>
---
  .../devicetree/bindings/arm/samsung/pmu.txt        |    5 +-
  arch/arm/boot/dts/exynos4.dtsi                     |    5 ++
  arch/arm/boot/dts/exynos5260.dtsi                  |    5 ++
  arch/arm/mach-exynos/common.c                      |   51 +++++++++++++-------
  arch/arm/mach-exynos/include/mach/map.h            |    3 --
  5 files changed, 47 insertions(+), 22 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.txt b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
index f1f1552..667a7f0 100644
--- a/Documentation/devicetree/bindings/arm/samsung/pmu.txt
+++ b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
@@ -2,14 +2,15 @@ SAMSUNG Exynos SoC series PMU Registers

  Properties:
   - compatible : should contain two values. First value must be one from following list:
+                  - "samsung,exynos4210-pmu" - for Exynos4210 and Exynos4x12 SoC,
                    - "samsung,exynos5250-pmu" - for Exynos5250 SoC,
-                  - "samsung,exynos5420-pmu" - for Exynos5420 SoC.
+                  - "samsung,exynos5420-pmu" - for Exynos5420 and Exynos5260 SoC.
                 second value must be always "syscon".

   - reg : offset and length of the register set.

  Example :
  pmu_system_controller: system-controller@10040000 {
-       compatible = "samsung,exynos5250-pmu", "syscon";
+       compatible = "samsung,exynos5250-pmu";

If you have removed "syscon" deliberately above, then you should also
remove the same in the
binding description which says "second value must be always "syscon".".


I believe that "syscon" should be still present as I don't see any code providing access to PMU registers to other drivers, that could replace the standard syscon interface, being added by this series.

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux