RE: [PATCH V3 2/8] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



David Miller <davem@xxxxxxxxxxxxx> :
> From: Byungho An <bh74.an@xxxxxxxxxxx>
> Date: Mon, 17 Mar 2014 13:43:37 -0700
> 
> > +static void sxgbe_tx_timer(unsigned long data) {
> > +	struct sxgbe_tx_queue *p = (struct sxgbe_tx_queue *)data;
> > +	sxgbe_tx_queue_clean(p);
> > +}
> 
> A empty line after local variable declarations please.
> 
> > +	SXGBE_FOR_EACH_QUEUE(SXGBE_TX_QUEUES, queue_num) {
> > +		struct sxgbe_tx_queue *p = priv->txq[queue_num];
> > +		p->tx_coal_frames =  SXGBE_TX_FRAMES;
> 
> Likewise.
> 
> > +	SXGBE_FOR_EACH_QUEUE(SXGBE_TX_QUEUES, queue_num) {
> > +		struct sxgbe_tx_queue *p = priv->txq[queue_num];
> > +		del_timer_sync(&p->txtimer);
> > +	}
> 
> Likewise.
> 
> Please audit your entire submission for this problem.
OK, will do that.

> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in the
body of
> a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at
> http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux