Andrew.an <bh74.an@xxxxxxxxxxx> :
[...]
> > > +struct sxgbe_core_ops {
> > > + /* MAC core initialization */
> > > + void (*core_init)(void __iomem *ioaddr);
[...]
> > > + /* adjust SXGBE speed */
> > > + void (*set_speed)(void __iomem *ioaddr, unsigned char speed);
> > > +};
> >
> > This indirection level is never used.
> Those are used, can you give more detail?
They are used but they always point to the same set of methods.
Those methods could thus be directly called.
[...]
> > > +/* SXGBE private data structures */
> > > +struct sxgbe_tx_queue {
> > > + u8 queue_no;
> > > + unsigned int irq_no;
> > > + struct sxgbe_priv_data *priv_ptr;
> > > + struct sxgbe_tx_norm_desc *dma_tx;
> >
> > You may lay things a bit differently.
> can you give more detail?
Bigger fields first, u8 at the end. It will save padding in the struct.
--
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
