On Fri, Feb 07, 2014 at 10:12:51AM +0530, Naveen Krishna Chatradhi wrote:
> This patch adds a new compatible and uses variant struct to support
> HSI2C module on Exynos5260. Updates the Documentation dt bindings.
> Also resets the module as an init sequence (Needed by Exynos5260).
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@xxxxxxxxxxx>
This patch has clearly not been tested :( Build failure!
> +struct exynos_hsi2c_variant {
> + unsigned int fifo_depth;
> +};
Why so many tabs? In general, I'd prefer one space.
> - exynos5_i2c_init(i2c);
> + exynos5_i2c_reset(i2c);
Is this a related change?
Attachment:
signature.asc
Description: Digital signature
