Re: [RFC PATCH v2 19/21] ARM: dts: exynos5250-arndale: add dsi and panel nodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/02/14 13:31, Andrzej Hajda wrote:
> The patch adds bridge and panel nodes.
> It adds also DSI properties specific for arndale board.
> 
> Signed-off-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx>
> ---
>  arch/arm/boot/dts/exynos5250-arndale.dts | 39 ++++++++++++++++++++++++++++++++
>  1 file changed, 39 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
> index a0a985d..7d666b1 100644
> --- a/arch/arm/boot/dts/exynos5250-arndale.dts
> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
> @@ -584,6 +584,45 @@
>  		};
>  	};
>  
> +	panel: panel {
> +		compatible = "boe,hv070wsa-100";
> +		power-supply = <&vcc_3v3_reg>;
> +		enable-gpios = <&gpd1 3 0>;
> +		port {
> +			panel_ep: endpoint {
> +				remote-endpoint = <&bridge_out_ep>;
> +			};
> +		};
> +	};
> +
> +	dsi_0: dsi@14500000 {
> +		vddcore-supply = <&ldo8_reg>;
> +		vddio-supply = <&ldo10_reg>;
> +		samsung,pll-clock-frequency = <24000000>;
> +		samsung,burst-clock-frequency = <320000000>;
> +		samsung,esc-clock-frequency = <10000000>;
> +		status = "okay";
> +
> +		bridge@0 {
> +			reg = <0>;
> +			compatible = "toshiba,tc358764";
> +			vddc-supply = <&vcc_1v2_reg>;
> +			vddio-supply = <&vcc_1v8_reg>;
> +			vddmipi-supply = <&vcc_1v2_reg>;
> +			vddlvds133-supply = <&vcc_3v3_reg>;
> +			vddlvds112-supply = <&vcc_1v2_reg>;
> +			reset-gpio = <&gpd1 6 1>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			port@1 {
> +				reg = <1>;
> +				bridge_out_ep: endpoint {
> +					remote-endpoint = <&panel_ep>;
> +				};
> +			};
> +		};
> +	};

Compared to what I've done on OMAP, you don't seem to specify the video
inputs for the tc358764 at all. In this case it's obvious, as the chip
is a child of the DSI master. But the chip could as well be controlled
via i2c, and so be placed as a child of the i2c nodes.

So even if the driver doesn't use it, maybe it would be more future
proof to have both input and output endpoints for the tc358764?

 Tomi


Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux