On 02/12/14 08:36, Olof Johansson wrote:
Hi,
Hi Olof,
Besides what Mark Rutland already commented on:
OK, thanks :-)
On Mon, Feb 10, 2014 at 10:29 PM, Kukjin Kim<kgene.kim@xxxxxxxxxxx> wrote:+/ { + model = "SAMSUNG GH7"; + compatible = "samsung,gh7";Model and compatible in the dtsi should probably always be overridden by a dts that includes it, so there's little use in having it here.
OK, makes sense.
Yes it's correct without any consideration, but I'm going to add more cpus next time and they should be separated from this. So I used.+ interrupt-parent =<&gic>; + #address-cells =<2>; + #size-cells =<2>; + + cpus { + #address-cells =<2>; + #size-cells =<0>; + + cpu@000 { + device_type = "cpu"; + compatible = "arm,armv8"; + reg =<0x0 0x000>;No need to zero-pad cpu numbers in unit address or reg.
+ enable-method = "spin-table"; + cpu-release-addr =<0x0 0x8000fff8>; + }; + cpu@001 { + device_type = "cpu"; + compatible = "arm,armv8"; + reg =<0x0 0x001>; + enable-method = "spin-table"; + cpu-release-addr =<0x0 0x8000fff8>; + }; + cpu@002 { + device_type = "cpu"; + compatible = "arm,armv8"; + reg =<0x0 0x002>; + enable-method = "spin-table"; + cpu-release-addr =<0x0 0x8000fff8>; + }; + cpu@003 { + device_type = "cpu"; + compatible = "arm,armv8"; + reg =<0x0 0x003>; + enable-method = "spin-table"; + cpu-release-addr =<0x0 0x8000fff8>; + }; + }; + + gic: interrupt-controller@1C000000 { + compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic";This looks incorrect -- you should at the very least have a more specific one than a15-gic? Marc?
OK, you're right. And I replied on other e-mail. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
