Re: [PATCH 1/1] ARM: EXYNOS: Consolidate Kconfig entries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sachin,

On 06.02.2014 12:59, Sachin Kamat wrote:
Instead of repeating the Kconfig entries for every SoC, move them under
ARCH_EXYNOS4 and 5 and move the entries common to both 4 and 5 under
ARCH_EXYNOS. Also, since the individual SoCs do not have any specific
machine/platform code, keep them as boolean symbols instead of user
selectable and select them from Exynos4 and 5 config symbols. Individual
SoC symbols can be removed eventually once the driver Kconfig dependencies
on these symbols are removed.

Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
---
  arch/arm/Kconfig             |   12 ++++++
  arch/arm/mach-exynos/Kconfig |   97 ++++++++++--------------------------------
  2 files changed, 35 insertions(+), 74 deletions(-)

I fully agree that there is no real need of having per-SoC Kconfig entries, since the differences caused by them are quite insignificant. Moreover, this makes me wonder if there is even need to distinguish between ARCH_EXYNOS4 and ARCH_EXYNOS5...

Anyway, I second this patch:

Acked-by: Tomasz Figa <t.figa@xxxxxxxxxxx>

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux