Re: [PATCH] ARM: dts: Add l2x0 device node for Exynos4-based boards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 24.01.2014 05:44, Tushar Behera wrote:
On 23 January 2014 23:45, Tomasz Figa <t.figa@xxxxxxxxxxx> wrote:
Hi,


On 07.01.2014 09:53, Tushar Behera wrote:

For Exynos4 platform, L2 cache initialization is done only if
a device node for l2x0 device exists.

L2 cache initialization path is different when a board boots with
secure firmware. Since there are many Exynos4 based SoCs that boot
in secure mode, enabling this only for boards that don't boot with
secure firmware.

Signed-off-by: Tushar Behera <tushar.behera@xxxxxxxxxx>
---

Tested on Exynos4210-Origen board.

   arch/arm/boot/dts/exynos4.dtsi                  |    8 ++++++++
   arch/arm/boot/dts/exynos4210-origen.dts         |    4 ++++
   arch/arm/boot/dts/exynos4210-smdkv310.dts       |    4 ++++
   arch/arm/boot/dts/exynos4210-trats.dts          |    4 ++++
   arch/arm/boot/dts/exynos4210-universal_c210.dts |    4 ++++
   arch/arm/boot/dts/exynos4412-odroidx.dts        |    4 ++++
   arch/arm/boot/dts/exynos4412-smdk4412.dts       |    4 ++++
   arch/arm/boot/dts/exynos4412-tiny4412.dts       |    4 ++++
   8 files changed, 36 insertions(+)


Looks good. Unfortunately this is still going to break secure firmware
enabled boards, because l2x0_of_init() does not check if the node is
enabled.


Is the following check in l2x0_of_init() not enough?

1002 |-------np = of_find_matching_node(NULL, l2x0_ids);
1003 |-------if (!np)
1004 |-------|-------return -ENODEV;

It only looks for a matching node without checking its status property.

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux