On Wed, 2014-01-22 at 19:49 +0000, Mark Brown wrote: > On Wed, Jan 22, 2014 at 05:07:28PM +0100, Krzysztof Kozlowski wrote: > > Add documentation for new bindings for controlling (enable/disable) the > > Buck9 Converter by GPIO (BUCK9EN). > > Your CC list for this is *very* large... Hmmm... The get_maintainers produces such long list for any change in Documentation/devicetree/bindings... I'll stop using it for this. > > > + - s5m8767,pmic-ext-control-enable: regulator can be enabled/disabled > > + by GPIO (valid only for buck9). > > + - s5m8767,pmic-ext-control-gpio: GPIO specifier for one GPIO > > + controlling this regulator (valid only for buck9). > > + This property is required when 's5m8767,pmic-ext-control-enable' is specified. > > In what situation might the GPIO be present but not usable - can't we > just use the presence of the GPIO property? Also GPIO properties are > supposed to be always "-gpios". Remove the "s5m8767,pmic-ext-control-enable" and use only "s5m8767,pmic-ext-control-gpios"? Sure, that makes sense. Thanks for idea. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |