Hi Kishon, Thank you for your review. > From: Kishon Vijay Abraham I [mailto:kishon@xxxxxx] > Sent: Monday, January 06, 2014 11:24 AM > > Hi, > > On Friday 20 December 2013 06:54 PM, Kamil Debski wrote: > > This the alternative version of the support for Exynos 421x USB 2.0 > > PHY in the Generic PHY framework. In this version the support for > > Exynos > > 4210 and 4212 was joined into one file. > > > > Signed-off-by: Kamil Debski <k.debski@xxxxxxxxxxx> > > --- > > Hi, > > > > Me and Kishon were discussing for quite a long time the way how > Exynos > > 4 should be handled. I have decided to post the original patches and > > try to make an alternative version with support for Exynos 4210 and > > 4212 joined in one file. I have prepared two versions. The first one > > has 506 lines (vs > > 563 when two files are used). When doing the second version I was a > > little more aggresive in removing code. This was done at a cost of > > adding if's deciding which SoC version the driver is dealing with in > some internal functions. > > This resulted in a better number of removed lines - the second > version > > has only 452 lines (vs 563 original and 506 version 1). > > Alright.. If the alternate approach doesn't give too much of advantage, > lets stick with the original one. I would recommend creating a > documentation (Documentation/phy/?) for the samsung PHY since that > actually creates a layer on top of generic PHY framework. That would > help while adding new samsung PHY drivers. Ok, I will prepare an updated set of patches with the documentation added. Also I will fix other issues you pointed out in reply to other patches from this series. > > Btw thank you for preparing alternate versions for your original > patches. No problem :) Best wishes, -- Kamil Debski Samsung R&D Institute Poland -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |