On 4 January 2014 08:05, <kgene@xxxxxxxxxx> wrote: > Tushar Behera wrote: >> >> On 31 December 2013 21:08, Mark Brown <broonie@xxxxxxxxxx> wrote: >> > On Mon, Dec 30, 2013 at 03:30:32PM +0530, Tushar Behera wrote: >> >> From: Sachin Kamat <sachin.kamat@xxxxxxxxxx> >> >> >> >> regs-serial.h only includes linux/serial_s3c.h. Include this >> >> header directly in samsung.S to remove unnecessary platform >> >> dependency. >> >> >> >> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx> >> >> --- >> > >> > If you're forwarding on a patch from someone else you need to add your >> > Signed-off-by to it - that's important for the whole goal of tracking >> > licensing. >> >> Yeah, true. I forgot about that. >> >> Signed-off-by: Tushar Behera <tushar.behera@xxxxxxxxxx> >> >> Kukjin, >> >> While applying this series, can you please add my Signed-off-by? >> > Tushar, The 'Signed-off-by' is different with others ack, review or whatever. In my understanding it's a legal issue so you need to repost. > > BTW, I think this series looks good to me but we don't need separated #1 to #8 patches because it's samething, so please squash them. > > Thanks, > Kukjin > Kukjin, I will repost the series after updating the sob and squashing the patches #2 to #9. I prefer to keep patch #1 separate as I would like to retain Sachin's authorship for that patch. -- Tushar Behera -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html