On Tue, Dec 31, 2013 at 8:17 AM, Mark Brown <broonie@xxxxxxxxxx> wrote: > On Sat, Dec 28, 2013 at 07:48:26PM -0800, Olof Johansson wrote: >> On Sat, Dec 28, 2013 at 7:44 PM, Olof Johansson <olof@xxxxxxxxx> wrote: > >> > The regulator driver causes build breaks. Really, nobody checks these >> > things before sending patches or merge requests? > >> > Having exynos_defconfig broken in arm-soc isn't an alternative. So I >> > dropped this branch again. If the regulator driver gets fixed in -rc >> > then we can probably merge it before the merge window, otherwise we'll >> > have to merge the defconfig change after the regulator fix goes in for >> > the 3.14 merge window. > >> Ah, I guess the fix went in after -rc4, which is the latest -rc that >> we have in for-next today. I'll bring for-next forward and merge this >> in. > >> Still, it's odd that you were able to test your branch before sending it in. > > The build breakage was only introduced in -rc4 - a MFD/RTC change went > in via Andrew's tree so it got no exposure in -next before it showed up > in Linus' tree which wasn't good. The fix was in by -rc5, looking at > the date on the pull request I expect that any testing against -next (as > opposed to arm-soc) would've been OK and since the branch is based on > -rc1 it'd have tested out by itself as well. Ah, yeah, that explains it. Thanks for the clarification. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |