Hi Jingoo, On 31 December 2013 12:17, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote: > On Tuesday, December 31, 2013 2:12 PM, Sachin Kamat wrote: >> >> plat/regs-nand.h is used only by s3c2410 nand driver. >> Move this file to the drivers folder to remove platform >> dependency. >> >> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx> > > Reviewed-by: Jingoo Han <jg1.han@xxxxxxxxxxx> Thanks. > However, how about consolidating this header into 's3c2410.c'? > This comment also applies to the patch "ata: pata_samsung_cf: Move > plat/regs-ata.h to drivers/ata". That was an option. However considering the size of the header files, I chose to keep them separate. Either way is fine with me though. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html