On Friday 20 of December 2013 13:22:06 Olof Johansson wrote: > On Fri, Dec 20, 2013 at 3:38 AM, Abhilash Kesavan > <kesavan.abhilash@xxxxxxxxx> wrote: > > Hi Sunil, > > > > On Fri, Dec 20, 2013 at 3:56 PM, sunil joshi <sjoshi.open@xxxxxxxxx> wrote: > >> Hi Abhilash, > >> I saw another patch in chrome tree ..by Andrew Bresticker > >> which may be relevant here .. > >> > >> Just wondering if you missed adding this ? or this is not needed ? > >> You did not face any issue in getting core to suspend ? > > > > This has not been added for Exynos5250 in mainline yet. We did notice > > that the system would fail to suspend on the rare occasion (~1% of the > > time on exynos5250) when we repeatedly suspended and resumed the > > system. > > > > I have not run s2r stress tests, but have had no issues suspending the > > system in my limited testing. We can probably let this be for now as > > the system would resume fine even on a failed suspend. I will do some > > stress testing and then post if needed. > > Hold on, you're claiming that this patch you've posted has only seen > very limited testing, and that you are aware of failures? > > Don't merge known-broken code into the mainline kernel. I'm afraid that a "failed suspend" does not really mean a failure here, but let me wait for clarification of things I asked in another part of this thread. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html