Am Donnerstag, 12. Dezember 2013, 15:06:50 schrieb Linus Walleij: > This isolates the custom S3C24xx GPIO definition table to > <linux/platform_data/gpio-samsung-s3x24xx.h> as this is > used in a few different places in the kernel, removing the > need to depend on the implicit inclusion of <mach/gpio.h> > from <linux/gpio.h> and thus getting rid of a few nasty > cross-dependencies. > > We also delete the nifty CONFIG_S3C24XX_GPIO_EXTRA stuff. > The biggest this can ever be for the S3C24XX is > CONFIG_S3C24XX_GPIO_EXTRA = 128, and then for CPU_S3C2443 or > CPU_S3C2416 32*12 GPIOs are added, so 32*12+128 = 512 > is the absolute roof value on this platform. So we set > the size of ARCH_NR_GPIO to this and the GPIOs array will > fit any S3C24XX platform, as per pattern from other archs. > > Cc: Heiko Stuebner <heiko@xxxxxxxxx> > Cc: Tomasz Figa <tomasz.figa@xxxxxxxxx> > Cc: Sylwester Nawrocki <sylvester.nawrocki@xxxxxxxxx> > Cc: Ben Dooks <ben-linux@xxxxxxxxx> > Cc: Kukjin Kim <kgene.kim@xxxxxxxxxxx> > Cc: linux-samsung-soc@xxxxxxxxxxxxxxx > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > --- > ChangeLog v1->v2: > - Added an #ifdef ARCH_S3C24XX around the header inclusion > in drivers/gpio/gpio-samsung.c as we would otherwise > have colliding definitions when compiling S3C64XX. > - Rename inclusion guard in the header file. > > If one of the maintainers give me an ACK for this I will > take it through the GPIO tree. > --- I'm not the maintainer of s3c24xx, but this looks nice ;-) Acked-by: Heiko Stuebner <heiko@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html