On 15 October 2013 11:36, Heiko Schocher <hs@xxxxxxx> wrote: > Hello Naveen, > > Am 15.10.2013 07:12, schrieb Naveen Krishna Chatradhi: > >> The Exynos5 i2c driver does not handle NACKs properly. This change: >> >> - fixes the NACK processing problem (do not continue transaction if >> address cycle was NACKed) >> >> - eliminates a fair amount of duplicate code >> >> Signed-off-by: Vadim Bendebury<vbendeb@xxxxxxxxxxxx> >> Reviewed-by: Simon Glass<sjg@xxxxxxxxxx> >> Signed-off-by: Naveen Krishna Chatradhi<ch.naveen@xxxxxxxxxxx> >> --- >> Changes since v1: >> Fixed complilation warning in function i2c_init() >> >> Changes since v2: >> None >> >> drivers/i2c/s3c24x0_i2c.c | 214 >> +++++++++++++++++++-------------------------- >> 1 file changed, 90 insertions(+), 124 deletions(-) > > > Hmm.. I think your patchset is for u-boot, or? But I could not find > the u-boot ml on cc... instead some linux ml ... if so, please resend > to the u-boot ml ... > > (matches for all three patches from you) I just checked that u-boot mailing list is missing. I've done the checks you mentioned in the other mail and reposted with u-boot@xxxxxxxxxxxxx in --to Thanks for your review. > > > bye, > Heiko > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany -- Shine bright, (: Nav :) -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html