On Fri, Oct 11, 2013 at 10:17:48AM +0530, Rajeshwari S Shinde wrote:
> This patch enables word transfer for s3c64xx spi driver.
> User can set bits_per_word to 32 before calling spi_setup,
> which would enable the word transfer mode.
As someone mentioned on previous reviews there's nothing in this patch
which sets bits_per_word_mask, you should be doing that.
> Changes in V3:
> - Corrected the coding style nits.
Not all of them:
> + if(sdd->cur_bpw == 32) {
checkpatch should've told you about this... I'd also expect this to be
a switch statement with a case for 16 bit words too?
> + /*
> + * Enable byte transfer if transfer length not a multiple of
> + * word size
> + */
> + if (xfer->len % (bpw / 8))
> + bpw = 8;
This check is redundant, the core will validate bits per word.
Attachment:
signature.asc
Description: Digital signature
