On 28 September 2013 10:37, Jungseok Lee <jays.lee@xxxxxxxxxxx> wrote: > > +static void exynos5440_power_off(void) > +{ > + struct device_node *np; > + void __iomem *addr; > + > + np = of_find_compatible_node(NULL, NULL, "samsung,exynos5440-clock"); > + > + addr = of_iomap(np, 0) + 0x14; > + > + __raw_writel(0x1, addr); Probably the magic numbers could be defined as macros or atleast a comment to that effect would be useful. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html