Tomasz, On Fri, Sep 27, 2013 at 11:14 AM, Tomasz Figa <tomasz.figa@xxxxxxxxx> wrote: >> So isn't the register in the PMU there to save power in the case that >> the watchdog timer isn't being used? How is the PMU "driver" to know >> whether the watchdog is being used? Better IMHO that the watchdog >> driver knows to enable and disable itself as needed, right? > > How much power can you save on one low frequency counter? Anyway, those > bits look more like reset signal masks to me, unrelated to any power > saving and even if, this driver switches them on at probe regardless of > whether the watchdog is actually used or not. I don't know for sure how much power it saves if any. The description I have of those fields is also definitely a little on the confusing side. The fact that they are in the PMU leads me to believe that they save power, but perhaps that's not the case here. It still does seem nice to keep watchdog related code in the watchdog driver, though... I guess I could also imagine ordering problems if we tweaked this bit in the PMU driver, though I don't have actual evidence of this. Maybe cases where enabling at the wrong time could cause spurious watchdog resets depending on how the BIOS left the state of things. It would be unfortunate if we found we needed to reach into the watchdog register bank from the PMU driver to "pet" the watchdog before enabling it. -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |