Hi Sachin,
I must have missed this patch so better later than never ;).
Please see my comments inline.
On Thursday 26 of September 2013 10:32:01 Sachin Kamat wrote:
> > + regulators {
> > + compatible = "simple-bus";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + mmc_reg: voltage-regulator {
For consistency and correctness, since this is a bus, even if not
physical, it is worth to add reg property and unit-address to subnodes.
Since this bus is not physical, the reg property would not be anything
more than purely an index.
Also for consistency I'd use "regulator" as node name here, as this is
what is used most commonly across all the dts files in arch/arm/boot/dts.
So you could have then (in case of more than one regulator)
regulators {
compatible = "simple-bus";
#address-cells = <1>;
#size-cells = <0>;
mmc_reg: regulator@0 {
/* ... */
reg = <0>;
};
xxx_reg: regulator@1 {
/* ... */
reg = <1>;
};
/* ... */
};
Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
