On Thursday 12 of September 2013 21:00:13 Mark Brown wrote: > On Thu, Sep 12, 2013 at 05:55:59PM +0200, Tomasz Figa wrote: > > On Thursday 12 of September 2013 14:52:33 Mark Brown wrote: > > > Please delete unneeded context from your mails, it makes it much > > > easier > > > to find the new content. > > > > I always snip unnecessary parts of quoted message if its really long, > > but if its length is in acceptable range then I try to keep the whole > > message just for reference. > > I tend to say that when I find myself paging through entire screens of > quote and can't see the relevance to any content I eventually find. Hmm, looking at it here from my desktop, I could have dropped some of the context between second and third reply indeed. > > i2c@12CA0000 does look like a normal hardware I2C controller, which > > needs some extra properties like samsung,i2c-sda-delay or > > samsung,i2c-max-bus- > Shouldn't these have sane defaults? AFAIK those parameters are highly board specific so it would be hard to set any reasonable default for them. > > freq. However they are specified in cros5250-common.dtsi, so I'd say > > that this might be better place for the status override as well. > > Can we rename that file to something like exynos5250-cros-common.dtsi > so that it's obvious it's relevant to exynos? I had completely failed > to notice that it was anything to do with Exynos when I was searching > for affected DTS files. > > Especially given that it's included in exactly one DTS at the minute... Yes, it would surely make sense to do so, unless there is another cros board that could use this dtsi and is based on another SoC, which I doubt, because there are multiple SoC specific values specified inside it. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |