On Mon, Sep 09, 2013 at 04:09:23PM +0200, Lukasz Czerwinski wrote: > The spi-s3c64xx currently doesn't support transfers from non-contiguous > client buffers. > > This patch adds two coherent buffers which allow transfers from > non-contiguous client buffers without extra coherent memory allocation > in the client driver. > > Buffer size is hardcoded to 16kB for Tx/Rx. Client drivers shouldn't > exceed that value. This seems like a very low limit to have, consider things like firmware downloads for example. It seems reasonable to have a preallocated small buffer but there should be some fallback for larger transfer sizes. I also didn't notice any checks in the code for the length of transfers so this will corrupt memory if a client driver tries to transfer more than the preallocated buffer as things stand.
Attachment:
signature.asc
Description: Digital signature
